On 11/30/2016 01:23 PM, Andrey Utkin wrote: > I'm quite sure this angry rant won't be pleasant to read for anybody, > but still I believe this post serves the good of Gentoo and this issue > is technical enough to be discussed on gentoo-dev. Also gentoo-pr list > seems retired anyway. > > This is a second time I've got into a situation when a new ebuild > submitted by me gets to mainline with minimal changes but not retaining > my authorship at all. > > First time it was here: https://github.com/gentoo/gentoo/pull/361 and my > rant was endorsed by monsieurp and the committer made excuses. > > This time the discussion between me and the committer has never > happened. > > My PR: https://github.com/gentoo/gentoo/pull/2765 > > My bugzilla ticket linked to it: > https://bugs.gentoo.org/show_bug.cgi?id=599088 > > After my pull request from Nov 6, the following commit gets into mainline: > > commit e19f46dfca967f4195eedf3f37a7882fbb37b796 > Author: Matthew Thode <prometheanf...@gentoo.org> > Date: Tue Nov 15 13:55:17 2016 -0600 > > dev-python/secretstorage: adding for keyring > > Package-Manager: portage-2.3.0 > > > The difference between my submission and final variant by Matthew is big > in number of lines, but is trivial in content as you can see below, so I > don't believe that Matthew has written his variant from scratch on his > own (he hasn't given any note on tickets on bugs.g.o or github), it > seems more like intentional swapping and amending original lines > retaining identical outcome. > > Not that authorship of one or two commits is so crucial for me, or that > I'm the most ambitious wannabe-contributor. Hell, there's not much of > code at all in the ebuild - it's trivial; but also not much is needed > here to give credit. I have contributed to quite some FOSS projects, and > have run into theft of my patches a couple of times, and it never was by > pure accident. > > I beg affiliated Gentoo developers to stay sane and be thinking not just > about numbers of your commits, but also about community spirit and > relationships. Of course inexperienced contributor gets things not right > first. In such cases, great maintainers fix that and retain original > authorship; good maintainers request for changes and resubmission. > > In no way I'm going to drift away from Gentoo because of this issue, no > alternatives around. (I even have a gradually maturing idea to become > Gentoo contributor on regular basis.) > > Just for record, a list of projects I've contributed to: FFmpeg, Linux > kernel, VLC, GStreamer, Kamailio, Mcabber, Gajim, v4l-utils. > > > [snip] >
I completely agree that we should credit (and thank) contributors. I'm not sure if I'm doing things correctly, but when I'm dealing with a bug and users contribute patches or edits to ebuilds, I try to credit them in my commit message, often asking them which nickname they'd prefer so I can give credit to the "right" name. Is this a practice you find adequate? Thanks for bringing this to attention. It's somewhat related to another discussion we've been having about copyright, and it may be worth considering protocol for situations like the one you've outlined. -- Daniel Campbell - Gentoo Developer OpenPGP Key: 0x1EA055D6 @ hkp://keys.gnupg.net fpr: AE03 9064 AE00 053C 270C 1DE4 6F7A 9091 1EA0 55D6
signature.asc
Description: OpenPGP digital signature
