On 11/30/2016 03:23 PM, Andrey Utkin wrote: > I'm quite sure this angry rant won't be pleasant to read for anybody, > but still I believe this post serves the good of Gentoo and this issue > is technical enough to be discussed on gentoo-dev. Also gentoo-pr list > seems retired anyway. > > This is a second time I've got into a situation when a new ebuild > submitted by me gets to mainline with minimal changes but not retaining > my authorship at all. > > First time it was here: https://github.com/gentoo/gentoo/pull/361 and my > rant was endorsed by monsieurp and the committer made excuses. > > This time the discussion between me and the committer has never > happened. > > My PR: https://github.com/gentoo/gentoo/pull/2765 > > My bugzilla ticket linked to it: > https://bugs.gentoo.org/show_bug.cgi?id=599088 > > After my pull request from Nov 6, the following commit gets into mainline: > > commit e19f46dfca967f4195eedf3f37a7882fbb37b796 > Author: Matthew Thode <prometheanf...@gentoo.org> > Date: Tue Nov 15 13:55:17 2016 -0600 > > dev-python/secretstorage: adding for keyring > > Package-Manager: portage-2.3.0 > > > The difference between my submission and final variant by Matthew is big > in number of lines, but is trivial in content as you can see below, so I > don't believe that Matthew has written his variant from scratch on his > own (he hasn't given any note on tickets on bugs.g.o or github), it > seems more like intentional swapping and amending original lines > retaining identical outcome. > > Not that authorship of one or two commits is so crucial for me, or that > I'm the most ambitious wannabe-contributor. Hell, there's not much of > code at all in the ebuild - it's trivial; but also not much is needed > here to give credit. I have contributed to quite some FOSS projects, and > have run into theft of my patches a couple of times, and it never was by > pure accident. > > I beg affiliated Gentoo developers to stay sane and be thinking not just > about numbers of your commits, but also about community spirit and > relationships. Of course inexperienced contributor gets things not right > first. In such cases, great maintainers fix that and retain original > authorship; good maintainers request for changes and resubmission. > > In no way I'm going to drift away from Gentoo because of this issue, no > alternatives around. (I even have a gradually maturing idea to become > Gentoo contributor on regular basis.) > > Just for record, a list of projects I've contributed to: FFmpeg, Linux > kernel, VLC, GStreamer, Kamailio, Mcabber, Gajim, v4l-utils. > > > diff --git a/336a45f661 b/98c5361d66 > index 336a45f661..98c5361d66 100644 > --- a/336a45f661 > +++ b/98c5361d66 > @@ -1,19 +1,27 @@ > -# Copyright 2016 Gentoo Foundation > +# Copyright 1999-2016 Gentoo Foundation > # Distributed under the terms of the GNU General Public License v2 > # $Id$ > > -EAPI="6" > -PYTHON_COMPAT=( python2_7 python3_{3,4,5} ) > +EAPI=6 > +PYTHON_COMPAT=( python{2_7,3_4,3_5} ) > > inherit distutils-r1 > > -DESCRIPTION="Python bindings to FreeDesktop.org Secret Service API" > -HOMEPAGE="http://pypi.python.org/pypi/SecretStorage"; > -SRC_URI="mirror://pypi/${PN:0:1}/${PN}/${P}.tar.gz" > +MY_PN="SecretStorage" > + > +DESCRIPTION="Python bindings to FreeDesktop.org Secret Service API." > +HOMEPAGE="https://github.com/mitya57/secretstorage > https://pypi.python.org/pypi/SecretStorage"; > +SRC_URI="mirror://pypi/S/${MY_PN}/${MY_PN}-${PV}.tar.gz" > > LICENSE="BSD" > SLOT="0" > -KEYWORDS="~amd64 ~x86" > +KEYWORDS="amd64 ~arm64 x86 ~amd64-linux ~x86-linux" > +IUSE="" > + > +DEPEND="dev-python/setuptools[${PYTHON_USEDEP}]" > + > +RDEPEND=" > + dev-python/cryptography[${PYTHON_USEDEP}] > + dev-python/dbus-python[${PYTHON_USEDEP}]" > > -RDEPEND="dev-python/dbus-python[${PYTHON_USEDEP}] > - dev-python/cryptography[${PYTHON_USEDEP}]" > +S="${WORKDIR}/${MY_PN}-${PV}" >
While I did see your PR and bug if I remember correctly I didn't actually use your commit or your ebuild to source it. I added it based on the bug iirc (which is still waiting on the link it seems). I should have mentioned that bug at the very least though and/or worked with you on the ebuild. Generally if committing from the community I will cherry-pick, which does retain authorship. Again, sorry about not updating the bug or waiting to work with you on the PR. If there's something else I can do for this let me know. -- -- Matthew Thode (prometheanfire)
signature.asc
Description: OpenPGP digital signature
