On Wed, 30 Nov 2016 17:17:16 -0500 Rich Freeman wrote: > On Wed, Nov 30, 2016 at 4:23 PM, Andrey Utkin <andrey_ut...@fastmail.com> > wrote: > > > > I beg affiliated Gentoo developers to stay sane and be thinking not just > > about numbers of your commits, but also about community spirit and > > relationships. Of course inexperienced contributor gets things not right > > first. In such cases, great maintainers fix that and retain original > > authorship; good maintainers request for changes and resubmission. > > > > ++ > > I'd have to hunt for where it is written down, but it can't be said > enough. We should definitely be trying to acknowledge the > contributions of others whenever possible. It is really the only > recognition a lot of "external" contributors get, and it is the least > we can do. This isn't about copyright or policy or anything like > that, but just a nice thing to do, and there is no "threshold" that > external contributors need to make. > > I wouldn't ascribe to malice what is probably just the result of > oversight, but it is a good reminder whatever the case may be... One more reason to use merge commits for pull requests: original author commits with proper authorship will be retained.
Yes, I know that some people are unhappy with non-linear history, but this is how git works, so there is nothing wrong with merge commits for user-contributed changes. Best regards, Andrew Savchenko
pgpcYPgLN8pRY.pgp
Description: PGP signature
