On 05/15/2016 03:55 PM, Duncan wrote: > Daniel Campbell posted on Sun, 15 May 2016 04:04:57 -0700 as excerpted: > >> If the dev in question hasn't done that before, then it's entirely >> possible they *thought* they tested, or tested it *before* making some >> other edit and absent-mindedly committed. > > Again, legacy CVS thought pattern. In git, commit != push, and it's the > push that's critical. > > Commit all you want without testing. Just test (and fix if necessary) > before you push those commits up to the gentoo master repo. =:^) > > (Of course, rebasing to fold the broken commit and its fix into one > before pushing doesn't hurt, either.) > Sorry. I've actually been using git for years, but since I got started with Gentoo on CVS and I try to be careful with my commits to the gentoo repo, I conflated them. You're right, the push is what matters the most.
-- Daniel Campbell - Gentoo Developer OpenPGP Key: 0x1EA055D6 @ hkp://keys.gnupg.net fpr: AE03 9064 AE00 053C 270C 1DE4 6F7A 9091 1EA0 55D6
signature.asc
Description: OpenPGP digital signature
