On Thu, 22 Sep 2011 10:58:28 +0000 "Jorge Manuel B. S. Vicetto" <jmbsvice...@gentoo.org> wrote:
> On 22-09-2011 08:11, Michał Górny wrote:
> > On Thu, 22 Sep 2011 09:01:17 +0200 Ulrich Mueller <u...@gentoo.org>
> > wrote:
> >
> >>> Attaching fixed version of the last two patches, and a
> >>> complete eclass for convenience.
> >>
> >> Just a general comment: Is it really necessary to change all [[
> >> -n ${foo} ]] and [[ -z ${foo} ]] conditionals to the more
> >> obscure [[ ${foo} ]] and [[ ! ${foo} ]]?
> >>
> >> The shortest possible form is not always the one that's best
> >> readable.
> >
> > The style change was approved by Donnie already.
>
> You mean that Donnie agreed with the style change. It's not up to any
> individual developer to "approve" such a change for the entire tree.
What kind of 'entire tree'? It is just a single eclass, and its
maintainer approves coding style change. Where do you see a problem
with that?
--
Best regards,
Michał Górny
signature.asc
Description: PGP signature
