On Thu, 22 Sep 2011 09:01:17 +0200 Ulrich Mueller <u...@gentoo.org> wrote:
> > Attaching fixed version of the last two patches, and a complete
> > eclass for convenience.
>
> Just a general comment: Is it really necessary to change all
> [[ -n ${foo} ]] and [[ -z ${foo} ]] conditionals to the more obscure
> [[ ${foo} ]] and [[ ! ${foo} ]]?
>
> The shortest possible form is not always the one that's best readable.
The style change was approved by Donnie already.
Also, this one looks better when a particular var is used as a 'bash
boolean', e.g. EVCS_OFFLINE, bare, etc. Then [[ ${EVCS_OFFLINE} ]] is
more explanatory than [[ -n ${EVCS_OFFLINE} ]].
--
Best regards,
Michał Górny
signature.asc
Description: PGP signature
