-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Dne 31.3.2011 09:51, Fabian Groffen napsal(a): > On 31-03-2011 09:41:10 +0200, Tomáš Chvátal wrote: >> Dne 31.3.2011 09:33, Fabian Groffen napsal(a): >>> On 31-03-2011 09:23:16 +0200, justin wrote: >>>> instead of the default >>>> >>>> mp3 - Add support for reading mp3 files >>> >>> I find the default clear enough. It seems the mp3 USE-flag is >>> overloaded with multiple functions, this is likely the cause of the >>> problem here. >>> >> The mp3 useflag is correct. It just can use mpg123 which is actualy >> better implementation and if you compile mplayer with -mp3 then it looks >> to libavcodec for the mp3 support (which is supposed to be worse than >> the mpg123). > > use.desc gives the default USE-description, which says it enables > support for reading mp3 files. Hence, (based on what you say) the > useflag is incorrect for mplayer, because it can *always* read > mp3-files. > > mplayer should not use mp3 USE-flag, because -mp3 to still have a > mp3-reading capable player feels quite counter-intuitive. It happens to > be that mp3 USE-flag is hooked up to the encode USE-flag -- this is > where it no longer has anything to do with the description from > use.desc. > > Well technically yep, but for lets say the ffmpeg the mp3 useflag means "Enable mp3 encoding support." :)
If user sets -mp3 it still can play mp3 tracks but in really worse quality so it is just nice convinience that ffmpeg always allows playing those files. Since i was that kind and disabled internal libmp3 that was first in order of what would be used simply with -mp3 you will get mplayer playing mp3 tracks but it is not desirable for you to do so. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk2UNx0ACgkQHB6c3gNBRYeKiQCgyoeAnZiTpvOz5cCuSQ32jU/W Cf0AoJdnIgdu9c/99Qy1i3gLkDIv77cB =99Me -----END PGP SIGNATURE-----
