Ulrich Mueller schrieb:
>>>>>> On Sun, 21 Sep 2008, Steve Long wrote:
> 
>> That works for that specific case, yes, but it's still not a general
>> solution, which is what BASH arrays were invented for. For instance,
>> an ebuild author cannot specifically include a file with spaces, and
>> ignore all the other files in the same directory.
> 
> The better solution would be to rename a such strange files ...
> How about an "edetox"? ;-)
> 
> And I still don't see why we would need the most general solution for
> a *default* function. There's always the possibility to write your own
> src_install() for the few ebuilds that need it.
> 
> Ulrich
> 
> 

I aggree with Ulrich in this case. This is just a suggestion for a default 
src_install funcion,
nothing that should cover every possible case. So if you have some special DOC 
that does not work
with the default install, you can still do it the normal way. So my suggestion 
for a default
src_install:

default_src_install() {
        if [ -f Makefile -o -f GNUmakefile -o -f makefile ]; then
                if emake DESTDIR="${D} install || einstall ; then
                        die "install failed"
                else
                        if [[ -n ${DOCS} ]]; then
                                dodoc ${DOCS} || die "dodoc failed"
                        fi
                fi
        fi
}

Any more comments? Good? Bad? Interested?

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to