On Saturday 17 June 2006 01:22, Alin Nastac wrote:
> Thomas Cort wrote:
> > What is the proper quoting style for using epatch? In the tree there
> > are about 3 different styles...
> >
> > epatch ${FILESDIR}/some-fix.patch # used by 7326 ebuilds
> > epatch "${FILESDIR}"/some-fix.patch # used by 3092 ebuilds
> > epatch "${FILESDIR}/some-fix.patch" # used by 1434 ebuilds
>
> 2 and 3 are fine.
correct ... personally i prefer the 2nd myself
> > What is the proper quoting style for defining the S variable? In the
> > tree there are about 3 different styles...
> >
> > S=${WORKDIR}/${MY_P} # used by 5270 ebuilds
> > S="${WORKDIR}"/${MY_P} # used by 43 ebuilds
> > S="${WORKDIR}/${MY_P}" # used by 2259 ebuilds
>
> ditto
not really ... all three will work fine, but i prefer the first myself as the
quoting is not needed here
-mike
pgp2CKQP3l9gx.pgp
Description: PGP signature
