On Sat, 17 Jun 2006, Thomas Cort wrote:
What is the proper quoting style for using epatch? In the tree there
are about 3 different styles...
epatch ${FILESDIR}/some-fix.patch # used by 7326 ebuilds
epatch "${FILESDIR}"/some-fix.patch # used by 3092 ebuilds
epatch "${FILESDIR}/some-fix.patch" # used by 1434 ebuilds
The second and third are fine. The quoting is needed since FILESDIR
is user-set and could contain a space.
What is the proper quoting style for defining the S variable? In the
tree there are about 3 different styles...
S=${WORKDIR}/${MY_P} # used by 5270 ebuilds
S="${WORKDIR}"/${MY_P} # used by 43 ebuilds
S="${WORKDIR}/${MY_P}" # used by 2259 ebuilds
The first is correct. The second and third have unnecessary quoting.
Michael Sterrett
-Mr. Bones.-
[EMAIL PROTECTED]
--
gentoo-dev@gentoo.org mailing list
