On Sat, Jun 17, 2006 at 12:35:30AM -0400, Thomas Cort wrote:
> What is the proper quoting style for using epatch? In the tree there
> are about 3 different styles...
>
> epatch ${FILESDIR}/some-fix.patch # used by 7326 ebuilds
> epatch "${FILESDIR}"/some-fix.patch # used by 3092 ebuilds
> epatch "${FILESDIR}/some-fix.patch" # used by 1434 ebuilds
${FILESDIR} should be quoted, but as long as there are no wildcards in
the "/some-fix.patch", it doesn't matter whether that is.
> What is the proper quoting style for defining the S variable? In the
> tree there are about 3 different styles...
>
> S=${WORKDIR}/${MY_P} # used by 5270 ebuilds
> S="${WORKDIR}"/${MY_P} # used by 43 ebuilds
> S="${WORKDIR}/${MY_P}" # used by 2259 ebuilds
Any is fine, there is no word splitting or wildcard expansion in
shell variable assignments.
> What is the purpose of setting DEPEND and RDEPEND to "" if DEPEND and
> RDEPEND are optional[1][2]? Isn't that just a waste of disk space /
> bandwidth?
RDEPEND defaults to DEPEND (in ebuilds), so if DEPEND is set, and
RDEPEND should be empty, then RDEPEND must be set to "" explicitly.
As for DEPEND="", that's mostly a stylistic issue, I think.
> DEPEND="virtual/libc" seems like a waste too as it is an
> implicit system dependency[3], any reason for using it?
Not really.
--
gentoo-dev@gentoo.org mailing list
