Hi Justin Thanks for your feedback. I will do the changes.
I'm very frustrated but I did all these changes before the previous release, but we got different "confusing" messages during the vote asking for changes. Anyway, let's move forward :) Regards JB On Sun, May 11, 2025 at 3:21 AM Justin Mclean <jus...@classsoftware.com> wrote: > > Hi, > > > 1. about Iceberg and Nessie NOTICE, during the 0.9.0 vote, you asked > > to remove it explicitly. > > I’d suggested that unneeded parts of the NOTICE file be removed, not the > entire contents. See [1] > > > Are you now asking to add it (as I did > > initially) ? And Iceberg NOTICE is not required as it's an ASF > > project. > > Any NOTICE is required as per [2] > > > 2. Is really ASF header a blocker ? I see the same on a lot of other > > ASF projects and podlings. For instance > > https://github.com/apache/gravitino/blob/main/gradle/wrapper/gradle-wrapper.properties. > > Yes it is, see [3]. i.e "Do not add the standard Apache License header to the > top of third-party source files.”. We’re not talking about one or two files > here, there are 20 or 30. > > Yes, the example you pointed out should be fixed (I’ve raised an issue). I > have voted -1 on Gravitino releases for precisely this reason [4], but I > missed that file. > > > 4. About the picocli dependency in the admin distribution, it's > > actually under the ASF license (not GPL): > > https://github.com/remkop/picocli/blob/main/LICENSE, I will fix that. > > 3rd parties do not always do the right thing with licensing and may, for > instance, say a package is Apache licensed when it contains Category X > licensed code. Code from OpenJDK is not Apache licensed. I did not look into > the exact details here, but it would be best to check if any OpenJDK ends up > in the source or binary. > > Kind Regards, > Justin > > 1. https://infra.apache.org/licensing-howto.html#bundle-asf-product > 2. https://infra.apache.org/licensing-howto.html#alv2-dep > 3. https://www.apache.org/legal/src-headers.html#3party > 4. https://lists.apache.org/thread/7o6jx91f91ql2p6xwf21mymrb7m78oy0 > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
