Thanks for the clarification Willem and Justin, I've updated the Incubator Release Checklist document [1] accordingly.
I hereby withdraw my -1 and below is my updated vote: +1 (binding) - Checked sum and signatures: OK - Checked DISCLAIMER file exists: OK - Checked LICENSE and NOTICE files: OK - Checked no binary files in source package: OK - Checked release file name and location: OK - Checked compile from source: OK (JDK 11u21) * Note: hugegraph-computer requires java 11 to compile but the current document [2] doesn't mention this (java 11 is marked as recommended but not required), and I suggest adding some notes. The other source packages could be compiled by java 8u101. Best Regards, Yu [1] https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist [2] https://hugegraph.apache.org/docs/contribution-guidelines/validate-release/ On Wed, 27 Dec 2023 at 14:33, Justin Mclean <jus...@classsoftware.com> wrote: > Hi, > > +1 (binding) > > I checked all source releases. > > - incubating in names > - all release include LICENSE, NOTICE and DISCLAIMER > - The NOTICE file for huge graph-computer could be improved, as it > contains unnecessary information. "Copyright 2012 and onwards JanusGraph > Authors” is clearly not correct. > - The NOTICE file for the main source release duplicate information, i.e. > "This product includes software developed at The Apache Software Foundation > (http://www.apache.org/).” and also includes text that is not required. > - No unexpected binary files > - All files have correct headers, except this file might have an incorrect > header. [1] > - was unable to compile but probably my setup > > Kind Regards, > Justin > > 1. > ./hugegraph-server/hugegraph-dist/src/assembly/static/bin/wait-storage.sh > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
