Hi all: We have made revisions one by one according to the issues pointed out by Justin (see : https://issues.apache.org/jira/browse/TUBEMQ-543). If anyone have any questions, please continue to point out, Thanks!
After all PRs are merged, we will initiate a new round of version release and vote. Thanks Justin again!! Goson zhang <gosonzh...@apache.org> 于2021年1月28日周四 下午8:05写道： > Hi Justin: > > I have understood the following questions, thanks: > > Thank you for your prompt reply, I understand. And there is one more > question for help: > > - NOTICE is missing information from other Apache licensed NOTICE files. > Information from these NOTICE files [5][6][7][10] will need to be added. > > We did it in the way of [6] [10]. What is the relationship between [5] [7] > and [6] [10]? When do you use the former mode to declare, and when do you > use the concise mode? > > > > > Goson zhang <gosonzh...@apache.org> 于2021年1月28日周四 上午11:56写道： > >> Hi Justin: >> >> Thank you for your prompt reply, I understand. And there is one more >> question for help: >> >> - NOTICE is missing information from other Apache licensed NOTICE files. >> Information from these NOTICE files [5][6][7][10] will need to be added. >> >> We did it in the way of [6] [10]. What is the relationship between [5] >> [7] and [6] [10]? When do you use the former mode to declare, and when do >> you use the concise mode? >> >> Thanks! >> >> Justin Mclean <jus...@classsoftware.com> 于2021年1月28日周四 上午11:46写道： >> >>> Hi, >>> >>> > 1. If the referenced file source has the original version statement, >>> we should keep it as it is and cannot replace it with the Apache v2 >>> statement? >>> >>> Correct. >>> >>> > 2. If the referenced file source does not have a version statement, >>> but the project of the file has a version statement, do we copy the license >>> statement of the project to the file header? >>> >>> I would just leave the file as it is. >>> >>> > 3. Do we still need to indicate which project the source of the >>> document comes from? >>> > such as[9]: >>> > /** >>> > * Utility for .ini configure file loading. >>> > * Copied from <a href="https://github.com/killme2008/Metamorphosis < >>> https://github.com/killme2008/Metamorphosis>">Metamorphosis Project</a> >>> > */ >>> >>> It best to mentioner that in LICENSE, but I see no harm in adding that. >>> >>> Thanks, >>> Justin >> >>
