Hi Justin,
Regarding the point 3, I have questions:
1. If the referenced file source has the original version statement, we
should keep it as it is and cannot replace it with the Apache v2 statement?
2. If the referenced file source does not have a version statement, but the
project of the file has a version statement, do we copy the license
statement of the project to the file header?
3. Do we still need to indicate which project the source of the document
comes from?
such as[9]:
> /**
> * Utility for .ini configure file loading.
> * Copied from <a
> href="https://github.com/killme2008/Metamorphosis";>Metamorphosis
> Project</a>
> */
>
9. Is this declaration in the
tubemq-server/src/main/java/org/apache/tubemq/server/tools/ToolUtils.java
Thanks!
Goson zhang <gosonzh...@apache.org> 于2021年1月28日周四 上午11:19写道：
> [image: image.png]
>
> Hi Justin:
>
> Regarding the third point, I don’t quite understand. Regarding [3] [4] [9]:
>
> 1. Is it necessary to remove the description of part B in the above
> screenshot?
>
> 2. If the file source itself does not have a LICENSE authorization
> statement, but the top level of the project is Apache V2 or other
> authorization agreements, should we add the corresponding authorization
> statement in the header of this file?
>
>
> 3. ./tubemq-client-twins/tubemq-client-cpp/src/any.h
> 4. ./tubemq-client-twins/tubemq-client-cpp/src/buffer.h
> 8.
> tubemq-core/src/main/java/org/apache/tubemq/corebase/utils/TStringUtils.java
> 9.
> tubemq-server/src/main/java/org/apache/tubemq/server/tools/ToolUtils.java
>
> Justin Mclean <jus...@classsoftware.com> 于2021年1月28日周四 上午11:10写道：
>
>> Hi,
>>
>> > - These files seem to have incorrect headers [1][2][3][4][8][9]. ASF
>> headers should include a copyright line and 3rd part headers need to be
>> kept unchanged.
>>
>> Sorry that should be "ASF headers should NOT include a copyright line”
>>
>> Thanks,
>> Justin
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
>> For additional commands, e-mail: general-h...@incubator.apache.org
>>
>>
