2017-10-23 8:32 GMT+02:00 Ate Douma <a...@douma.nu>: > +1 (binding) >
> One improvement to consider for the next release is appending the > license for Knockout (MIT) to the embedded LICENSE in the build ko4j > jar artifact, as is required for distributing this artifact. > I see. Good observation. I've reported: https://issues.apache.org/jira/browse/NETBEANS-98 and I fix it by next release. > And another is maybe generating a more explicit artifact name for ko4j. > For reasons of backward compatibility I prefer to keep the current (very short; sorry) name. There already have been few releases of this artifact before the code was donated to Apache: http://search.maven.org/#search%7Cgav%7C1%7Cg%3A%22org.netbeans.html%22%20AND%20a%3A%22ko4j%22 changing the name would only complicate upgrade from pre-Apache versions. Thanks for the review. -jt > Hi. > The NetBeans incubating community has just approved the release of >> HTML/Java API version 1.5. See the discussion at >> https://s.apache.org/00WM >> which contains the technical information as well as all the +1 votes >> including one by Bertrand, the NetBeans incubating community mentor. As a >> result of such unison approval, I'd like to ask you to hold the Incubator >> PMC vote to release: >> >> https://dist.apache.org/repos/dist/dev/incubator/netbeans/ >> >> as NetBeans HTML/Java Incubating API version 1.5. Can you cast your votes >> in next 72h, please? >> >> I am copying here the evaluation as done by Bertrand: >> >> >> I have reviewed >>> >> >> $SHA1(incubating-netbeans-html4j-1.5.zip)= >>> >> >> fd77975f1adbcbc4b926e1cfab6865f47db6df3c >>> >> >> >>> >> +1 for releasing that (after the Incubator PMC vote) >>> >> >> >>> >> signatures and digests match. >>> >> >> >>> >> LICENSE, NOTICE, DEPENDENCIES look good to me. >>> >> >> >>> >> The dependency on json.org will need to be removed ( >>> >> >> https://www.apache.org/legal/resolved.html ) - is there a jira ticket >>> >> >> for this? I think it's ok to release as is, provided there's a plan to >>> >> >> remove it. >>> >> >> >> FYI: the bug is reported as >> https://issues.apache.org/jira/browse/NETBEANS-89 and its fix is ready to >> be integrated in the next version of HTML/Java API. >> >> >> The archive doesn't contain binary files except for a few PNG images. >>> >> >> >>> >> The RAT report passes, with the following exclusions: >>> >> >> Exclude: **/*.sigtest >>> >> >> Exclude: **/.git/** >>> >> >> Exclude: **/.maven/** >>> >> >> Exclude: **/.repository/** >>> >> >> Exclude: **/target/** >>> >> >> Exclude: .gitignore >>> >> >> Exclude: DEPENDENCIES >>> >> >> Exclude: README.md >>> >> >> >>> >> FWIW, in case someone wants to review the changes to the license >>> >> >> headers they have apparently be made in these two commits: >>> >> >> >>> >> >>> https://github.com/apache/incubator-netbeans-html4j/commit/ >> a262480a0126b6797 >> >> 5389685925bf5c3e13b4061 >>> >> >> >>> https://github.com/apache/incubator-netbeans-html4j/commit/ >> b4fdfc8314c80730 >> >> 59e91de4eea586d194a6b76f >>> >> >> >>> >> -Bertrand >>> >> >> >> Thanks in advance for your votes. >> -jt >> >> > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
