In which case +1
from me as well. LieGrue, strub > Am 31.03.2017 um 19:27 schrieb Mike Jumper <mike.jum...@guac-dev.org>: > > On Fri, Mar 31, 2017 at 9:00 AM, Josh Elser <els...@apache.org> wrote: > >> Mike Jumper wrote: >> >>> * guacamole-auth-header includes some copies of ALv2 and mentions in your >>>>> LICENSE file. You only need to propagate the copyright notice here, >>>> not the >>>>> license text (since you already have that once). Looks like this >>>> might be >>>>> the case around the binary tarballs. >>>>> >>>>> >>>> >>> Are you referring to the copies of the ALv2 LICENSE for dependencies that >>> happen to have that license? >>> >>> I'm rather partial to the consistency of always having a copy of the >>> upstream license within a systematically-named directory structure, >>> regardless of whether the text of that license is the same as the license >>> of the project bundling it. >>> >> >> Yup. I understand your reasoning for doing that and that's fine. I just >> wanted to point out that it was unnecessary (as you had already included a >> copy of it the license text). >> >> > Ah, OK then. > > Thanks for the thorough review, Josh! > > - Mike --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
