On Thu, Mar 30, 2017 at 3:30 PM, Josh Elser <els...@apache.org> wrote:
> +1 (binding) > > * Could build the client, but I don't have a setup to build the server > * DISCLAIMER in every artifact > * Sufficient LICENSE & NOTICE files. Even in the WAR! Good job :) > * Commits exist in SCM > * Sigs/xsums OK > > In the future: > > * Your copyright in NOTICE files needs updating (2017) > OK. > * Dockerfile Maintainer line should be the Apache Guacamole community > (instead of your email). I assume this was just missed in the transition > Exactly. This is fixed now on git, so should be fine for next release and onward. It turns out that the "MAINTAINER" Dockerfile instruction is deprecated now, anyway, so we simply removed it: https://issues.apache.org/jira/browse/GUACAMOLE-251 > * Please include SHA1's from Git. The tag name could be modified easily. > OK. > * guacamole-auth-header includes some copies of ALv2 and mentions in your > LICENSE file. You only need to propagate the copyright notice here, not the > license text (since you already have that once). Looks like this might be > the case around the binary tarballs. > > Are you referring to the copies of the ALv2 LICENSE for dependencies that happen to have that license? I'm rather partial to the consistency of always having a copy of the upstream license within a systematically-named directory structure, regardless of whether the text of that license is the same as the license of the project bundling it. - Mike
