On 29 June 2016 at 21:06, Josh Elser <els...@apache.org> wrote: > +1 (binding)
Thanks, Josh! > - command-line's NOTICE has a vague reference as the other projects to > "Copyright 2010-2014 University of Manchester, UK", but not explicitly what > applies. Might that be clarified (if it's simple). It's tricky to be more specific, because for all three repositories most of the code comes from the software grant from Manchester and was developed between 2007-2014, but the start year varies per repository corresponding to their earliest commit. The exception is where there's something brand new added in the last years, e.g. GSOC 2016 is adding two new modules to common-activities, I guess for those we can clarify that they are not included by the Manchester (c). I agree that the NOTICE should try to make it clear when the additional lines can be disregarded, as an example this came up in Apache Commons VFS, which had borrowed code from Apache Jackrabbit, but we had to verify that code did NOT come from the original grant when Jackrabbit entered the incubator [4], and thus did not need to modify VFS's NOTICE. > Portions of this software were originally based on the following: > - Copyright 2007-2014 University of Manchester, UK > These have been licensed to the Apache Software Foundation under a software > grant. Perhaps we should also work on the exact wording here, that was also suggested by Justin. Do we need to mention the software grant? (We thought we should include it as the pre-2014 Taverna code was licensed as LGPL 2.1, which the git log should show) > The API jar didn't > contain that portion in its META-INF/NOTICE, but I'm unsure if it actually > contains code that the Uni has copyright over. Perhaps it really should, however University of Manchester is not going to insist on propagating this in META-INF/NOTICE as the code didn't have such a NOTICE when we did the software grant and code import [1]. We added Manchester to the top-level NOTICE mainly as a courtesy and to be true to history (the software was not started in 2014). The META-INF/NOTICE of most JAR files are auto-generated by maven-shared-archive-resources applied by the Apache super POM - and therefore do not mention Manchester. I don't know a good way to customize this without adding 100s of src/main/resources/META-INF/NOTICE or LICENSE files, as we have done now only where legally needed. [3] Thanks for your review! [1] https://github.com/apache/incubator-taverna-engine/tree/apache-import-20150223 [2] https://github.com/apache/incubator-taverna-language/blob/master/NOTICE [3] https://github.com/apache/incubator-taverna-engine/blob/master/taverna-execution-hadoop/src/main/resources/META-INF/LICENSE#L204 [4] https://issues.apache.org/jira/browse/VFS-611 -- Stian Soiland-Reyes Apache Taverna (incubating), Apache Commons http://orcid.org/0000-0001-9842-9718 --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
