On 18 June 2016 at 01:50, Justin Mclean <jus...@classsoftware.com> wrote: > Hi, > > +1 (binding). Can you fix the LICENSE and NOTICE issues in the next release > please.
Thank you - already fixed in master. Getting smarter every day.. > I can help by reviewing the release but I’m at my limit mentor wise sorry. Always appreciated - thanks! > - able to compile all from source but it seems the order matters (i.e. you > need to compile the engine first) you may want to mention that in README if > it’s not already Of course once these are in Maven Central it won't be a big blocker in the end. However I agree the build order should be more explicit, so I have added for the future: https://github.com/apache/incubator-taverna-engine#prerequisites https://github.com/apache/incubator-taverna-common-activities#prerequisites https://github.com/apache/incubator-taverna-commandline#prerequisites (Note that the linked download pages for engine/common-activities are only on http:// taverna.staging.apache.org/ for now) > In apache-taverna-commandline-3.1.0-incubating > - wording in NOTICE is is a little odd but probably fine. I guess you mean this section? > Portions of this software were originally based on the following: > - Copyright 2010-2014 University of Manchester, UK > These have been licensed to the Apache Software Foundation under a software > grant. This is how it was suggested to us by our mentors; but we're open for improvements - this text is the same across our NOTICEs (however the start-year might vary depending on the code base). Semantically I guess the software is not based on a copyright.. :) How about: > Portions of this software is: > - Copyright 2010-2014 University of Manchester, UK > These have been licensed to the Apache Software Foundation under a software > grant. ? > - year in NOTICE needs updating Bah - thanks. Updated. :) > In apache-taverna-common-activities-2.1.0-incubating > - W3C license info should be moved to LICENSE or preferably to it own file > and a pointer to that file added [1] Done - https://issues.apache.org/jira/browse/TAVERNA-986 > - LICENSE is missing license for this file [3] Oops! Well spotted. It is Public Domain, so there is obviously no requirement to propagate any license, But is "Public Domain" valid outside US? Should we append ASF headers on it? (That should be allowed if it's PD.. at least if that is done by an USAnian) Anyway, for information purposes I've added to top-level LICENSE --------------------------------------------------------- ./taverna-interaction-activity/src/main/resources/json2.js is Public Domain, see https://github.com/douglascrockford/JSON-js/ and http://www.json.org/js.html ------------------------------------------------------- > In apache-taverna-engine-3.1.0-incubating > - The licence of this file [2] needs to be mentioned in LICENSE not NOTICE > [1]. A pointer to the license file is preferred. Done. https://issues.apache.org/jira/browse/TAVERNA-985 (Also as you suggested I put it in META-INF/LICENSE rather than META-INF/NOTICE) -- Stian Soiland-Reyes Apache Taverna (incubating), Apache Commons http://orcid.org/0000-0001-9842-9718 --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
