On 20 June 2016 at 12:24, Sergio Fernández <wik...@apache.org> wrote: > +1 (binding)
Thanks! Much appreciated! > Non-blocking details I noticed (should be fixed in the next releases): > * The three artifacts are related with each other, so I'd include some > extra build information about the order when each one needs to be built. Agreed. Added: https://github.com/apache/incubator-taverna-engine#prerequisites https://github.com/apache/incubator-taverna-common-activities#prerequisites https://github.com/apache/incubator-taverna-commandline#prerequisites > * Some licensing details in NOTICE files (e.g., BSD 3-Clause at > apache-taverna-engine-3.1.0-incubating/NOTICE and W3C > apache-taverna-common-activities-2.1.0-incubating/NOTICE) need to be fixed: Fixed: https://issues.apache.org/jira/browse/TAVERNA-985 https://issues.apache.org/jira/browse/TAVERNA-986 https://issues.apache.org/jira/browse/TAVERNA-987 > * All NOTICE files should be aligned in wording and format (e.g., > apache-taverna-commandline-3.1.0-incubating/NOTICE contains wrong year). Fixed - although we should probably improve the "based on" wording. > Besides that, the release looks fine for me. Congratulations for such > milestone, guys! Thanks for reviewing! -- Stian Soiland-Reyes Apache Taverna (incubating), Apache Commons http://orcid.org/0000-0001-9842-9718 --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
