Lines like this are contents for the notice file, not license file:
This product includes jQuery (http://jquery.org - MIT license), Copyright © 2014, John Resig. license file should include the various licenses covering these works. On Mon, Jun 20, 2016 at 3:07 PM Velmurugan Periasamy <v...@apache.org> wrote: > Hi Justin: > > I would like to get your feedback on updated LICENSE.txt for Ranger. > https://github.com/apache/incubator-ranger/blob/master/LICENSE.txt > > Please see below answers to your questions. Ranger dev community is > getting prepared for the next major release, so getting your feedback and > approval on license would be critical. Thanks for your help. > > << > Minor issues: > LICENSE is missing MIT licensed Search Icon CSS copyright Nicolas > Gallagher bundled in (1) > Added PURE CSS GUI ICONS to LICENSE.txt > Is the copyright on this files correct? (2)(3) if so what projects did > they come from? (may effect content of NOTICE file) > (2) -> Added Jisql license. > (3) -> This file comes with Spring Security. Added that to LICENSE.txt > LICENSE is missing MIT licensed es5-shim copyright Kristopher Michael > Kowal bundled in (4) > Added to LICENSE.txt > LICENSE is missing SIL licensed FontAwesome (9) > Added to LICENSE.txt > LICENSE is missing reset.css. (7) Note this version bundled may not be > public domain unlike this one (8) so you may need to sort that out. > Added a note in LICENSE.txt > LICENSE is missing MIT licensed sizzle.js bundled in several files (10) > Added to LICENSE.txt > LICENSE is missing MIT license javascript diff engine in (11) > File was not used, removed the file. > I think handle bars require plugin is not WTFPL but MIT or BSD? (12) May > require further investigation. > Added a note in LICENSE.txt > LICENSE is missing public domain json2.js (13) > Added to LICENSE.txt > LICENSE is missing BSD licensed easing equations from Robert Penner (15) > in this file (14) > Added a note in LICENSE.txt > This is a more serious concern (and has been asked before): > How is this file licensed? (5) or this one? (6) > These files are not used, removed the files. > 1. > ./apache-ranger-incubating-0.5.3/security-admin/src/main/webapp/libs/bower/backgrid-filter/css/backgrid-filter.css > 2. > ./apache-ranger-incubating-0.5.3/jisql/src/main/java/org/apache/util/sql/Jisql.java > 3. > ./apache-ranger-incubating-0.5.3/security-admin/src/test/java/org/apache/ranger/service/PasswordComparisonAuthenticator.java > 4. > ./apache-ranger-incubating-0.5.3/security-admin/src/main/webapp/libs/other/backgrid/backgrid.js > 5. > ./apache-ranger-incubating-0.5.3/security-admin/src/main/webapp/libs/bower/globalize/generator/HijriCalendar.js > 6. > ./apache-ranger-incubating-0.5.3/security-admin/src/main/webapp/libs/bower/globalize/generator/UmAlQuraCalendar.js > 7. > ./apache-ranger-incubating-0.5.3/security-admin/src/main/webapp/libs/other/visualsearch/css/reset.css > 8. http://meyerweb.com/eric/tools/css/reset/reset.css > 9. > apache-ranger-incubating-0.5.3/security-admin/src/main/webapp/fonts/fontawesome/FontAwesome.otf > 10. ./security-admin/src/main/webapp/libs/bower/jquery/js/jquery.js > 11. > ./security-admin/src/main/webapp/libs/bower/globalize/test/qunit/qunit.js > 12. > /security-admin/src/main/webapp/libs/bower/require-handlebars-plugin/js/hbs.js > 13. > ./security-admin/src/main/webapp/libs/bower/require-handlebars-plugin/js/json2.js > 14. > ./security-admin/src/main/webapp/libs/other/jquery-ui/js/jquery-ui-1.10.3.custom.js > 15 http://robertpenner.com/easing/ > >> > > Thank you, > Vel > > On May 20, 2016, at 11:25 AM, Velmurugan Periasamy <v...@apache.org> wrote: > > > Thank you so much Justin. I’ll do the below. > > > > 1] Initiate another RC for 0.5.3. > > 2] Track these issues in > https://issues.apache.org/jira/browse/RANGER-964 and target to address in > 0.6.0 > > > > Regarding your question on [5] and [6] below, I believe these files are > covered under jquery globalize license. I will double check and resolve it > as needed in next release. > > > >> This is a more serious concern (and has been asked before): > >> - How is this file licensed? [5] or this one? [6] > > > > > > Thank you for your help, > > Vel > > > > On May 19, 2016, at 8:11 PM, Justin Mclean <jus...@classsoftware.com> > wrote: > > > >> Hi, > >> > >> Still needs some work IMO but if a JIRA was raised to fix these issues > in a later release I’d vote +1 on a new RC without these fixes. Just as > long as it’s all sorted before graduation. > >> > >> Minor issues: > >> - LICENSE is missing MIT licensed Search Icon CSS copyright Nicolas > Gallagher bundled in [1] > >> - Is the copyright on this files correct? [2][3] if so what projects > did they come from? (may effect content of NOTICE file) > >> - LICENSE is missing MIT licensed es5-shim copyright Kristopher Michael > Kowal bundled in [4] > >> - LICENSE is missing SIL licensed FontAwesome [9] > >> - LICENSE is missing reset.css. [7] Note this version bundled may not > be public domain unlike this one [8] so you may need to sort that out. > >> - LICENSE is missing MIT licensed sizzle.js bundled in several files > [10] > >> - LICENSE is missing MIT license javascript diff engine in [11] > >> - I think handle bars require plugin is not WTFPL but MIT or BSD? [12] > May require further investigation. > >> - LICENSE is missing public domain json2.js [13] > >> - LICENSE is missing BSD licensed easing equations from Robert Penner > [15] in this file [14] > >> > >> This is a more serious concern (and has been asked before): > >> - How is this file licensed? [5] or this one? [6] > >> > >> As there this is very complex there may of been a couple of things I > missed. > >> > >> Thanks, > >> Justin > >> > >> 1. > ./apache-ranger-incubating-0.5.3/security-admin/src/main/webapp/libs/bower/backgrid-filter/css/backgrid-filter.css > >> 2. > ./apache-ranger-incubating-0.5.3/jisql/src/main/java/org/apache/util/sql/Jisql.java > >> 3. > ./apache-ranger-incubating-0.5.3/security-admin/src/test/java/org/apache/ranger/service/PasswordComparisonAuthenticator.java > >> 4. > ./apache-ranger-incubating-0.5.3/security-admin/src/main/webapp/libs/other/backgrid/backgrid.js > >> 5. > ./apache-ranger-incubating-0.5.3/security-admin/src/main/webapp/libs/bower/globalize/generator/HijriCalendar.js > >> 6. > ./apache-ranger-incubating-0.5.3/security-admin/src/main/webapp/libs/bower/globalize/generator/UmAlQuraCalendar.js > >> 7. > ./apache-ranger-incubating-0.5.3/security-admin/src/main/webapp/libs/other/visualsearch/css/reset.css > >> 8. http://meyerweb.com/eric/tools/css/reset/reset.css > >> 9. > apache-ranger-incubating-0.5.3/security-admin/src/main/webapp/fonts/fontawesome/FontAwesome.otf > >> 10. ./security-admin/src/main/webapp/libs/bower/jquery/js/jquery.js > >> 11. > ./security-admin/src/main/webapp/libs/bower/globalize/test/qunit/qunit.js > >> 12. > /security-admin/src/main/webapp/libs/bower/require-handlebars-plugin/js/hbs.js > >> 13. > ./security-admin/src/main/webapp/libs/bower/require-handlebars-plugin/js/json2.js > >> 14. > ./security-admin/src/main/webapp/libs/other/jquery-ui/js/jquery-ui-1.10.3.custom.js > >> 15 http://robertpenner.com/easing/ > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > >> For additional commands, e-mail: general-h...@incubator.apache.org > >> > > > >
