Hi Yingzhen,
On Wed, Jan 29, 2025 at 6:02 PM Yingzhen Qu <yingzhen.i...@gmail.com> wrote: > Hi Behcet, > > Thanks for the review. I've uploaded version -24 to address your comments. > Detailed answers below inline. > > Thanks, > Yingzhen > > On Wed, Jan 29, 2025 at 9:03 AM Behcet Sarikaya via Datatracker < > nore...@ietf.org> wrote: > >> Reviewer: Behcet Sarikaya >> Review result: Ready with Nits >> >> I am the assigned Gen-ART reviewer for this draft. The General Area >> Review Team (Gen-ART) reviews all IETF documents being processed >> by the IESG for the IETF Chair. Please treat these comments just >> like any other last call comments. >> >> For more information, please see the FAQ at >> >> <https://wiki.ietf.org/en/group/gen/GenArtFAQ>. >> >> Document: draft-ietf-isis-sr-yang-23 >> Reviewer: Behcet Sarikaya >> Review Date: 2025-01-29 >> IETF LC End Date: 2025-01-30 >> IESG Telechat date: Not scheduled for a telechat >> >> Summary: >> This document develops a YANG data module for the purpose of configuring >> and >> managing >> >> IS-IS segment routing in the MPLS data plane. As such a large part of it >> consists of YANG code in Sections 3 and 4. >> >> Major issues: >> >> Minor issues: >> >> Nits/editorial comments: >> It has the following nits: >> >> idnits tool says there are 3 long (>72) lines. >> > > [Yingzhen]: fixed. > >> >> Appendix A has not been referenced. >> > > [Yingzhen]: Appendix A just provides a configuration example as most YANG > documents. I don't think it needs to be referenced. > Maybe in the introduction add a sentence: Appendix A provides a configuration example in XML. > >> Spell out the acronyms like IS IS-IS, MPLS, etc. in first use. >> > > [Yingzhen]: These terms are so well-known. I will leave these to the RFC > editor to decide whether they need to be expanded. > Frankly not for me :) Behcet
_______________________________________________ Gen-art mailing list -- gen-art@ietf.org To unsubscribe send an email to gen-art-le...@ietf.org
