I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed by the
IESG for the IETF Chair. Please treat these comments just like any other
last call comments. For more information, please see the FAQ at
<http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.
Document: draft-ietf-i2rs-yang-l3-topology-08
Reviewer: Paul Kyzivat
Review Date: 2017-01-13
IETF LC End Date: 2017-01-17
IESG Telechat date:
Summary:
This draft is on the right track but has open issues, described in the
review.
Disclaimer:
I started this review without any knowledge of YANG modeling. So the
sort of review I can do is superficial.
Issues:
Major: 0
Minor: 2
Nits: 1
(1) Minor:
In sections 4 & 5, one of the termination-point-types is called
"unnumbered", and contains an "unnumbered-id". But the value contained
here is in fact a uint32 *index* value. This clearly *is* a number. So,
ISTM that "unnumbered" is a misleading name for this element.
I gather it designates a termination point that is identified by this
index rather than by a name or an ip-address. If so, a better name might
be "index" or "indexed".
(2) Minor:
The examples in section 6.2 seem very helpful. But is it really
necessary to fill in so much detail? The amount of detail seems to make
it overly difficult to grasp the essential features. For instance, the
contact and description information could be shortened.
(3) NIT:
In section 1, s/augments general network/augments the general network/
_______________________________________________
Gen-art mailing list
Gen-art@ietf.org
https://www.ietf.org/mailman/listinfo/gen-art
