On Sun, 6 Sep 2020 at 16:23, Iain Sandoe <i...@sandoe.co.uk> wrote: > > Hi > > g++.dg/abi/guard3.C > > has: > > extern "C" int __cxa_guard_acquire(); > > Which might not be a suitable declaration, depending on how the ‘extern > “C”’ is supposed to affect the function signature generated. > > IF, the extern C should make this parse as a “K&R” style function - then > the TYPE_ARG_TYPES should be NULL (and the testcase is OK). > > However, we are parsing the decl as int __cxa_guard_acquire(void) (i.e. C++ > rules on the empty parens), which makes the testcase not OK.
That is the correct parse. Using extern "C" doesn't mean the code is C, it only affects mangling. It still has to follow C++ rules. In practice you can still link to the definition, because its name is just "__cxa_guard_acquire" irrespective of what parameter list is present in the declaration. > This means that the declaration is now misleading (and it’s just luck that > expand_call happens to count the length of the TYPE_ARG_TYPES list without > looking to see what the types are) - in this case it happens to work out > from this luck - since there’s only one arg so the length of the void args > list agrees with what we want. > > —— > > So .. the question is “which is wrong, the test-case or the assignment of > the TYPE_ARG_TYPES”? > > [we can’t easily diagnose this at this point, but I do have a patch to > diagnose the case where we pass a void-list to expand_call and then try to > expand a call to the callee with an inappropriate set of parms] > > (it’s trivial to fix the test-case as extern "C" int > __cxa_guard_acquire(__UINT64_TYPE__ *);, I guess) But PR 45603 is ice-on-invalid triggered by the incorrect declaration of __cxa_guard_acquire. So the incorrect declaration is what originally reproduced the bug, and "fixing" it would make the test useless. It's probably worth adding a comment about that in the test. Maybe the test should give a compile-time error and XFAIL, but fixing the declaration doesn't seem right.
