On Sat, Jan 11, 2020 at 09:15:11AM -0500, Jason Merrill wrote:
> > On Fri, Jan 10, 2020 at 10:47:47PM +0100, Jakub Jelinek wrote:
> > > Ah, you suggested g: rather than just g.
> > > We could then support
> > > rNNNNN (1-6 decimal digits) - the svn revs, either for old repo, or
> > transformed
> > > g:XXXXX (X is any [0-9a-zA-Z_-], something else?, 1 or more chars) -
> > gitweb with XXXXX
> >
>
> I was thinking that anything at all after g: should go to gitweb.
For the redirect perhaps. For bugzilla comments, it needs to know where it
does stop and shouldn't match unrelated text, plus as I wrote in the
bugzilla tweaks PR, not sure how smart are e.g. g:master or g:master^^ or
g:releases/gcc-9@{yesterday} references (and, there we at least shouldn't
match whitespace).
> > > rNN-MMMMM (1-2 decimal digits, 1-6 decimal digits) - git undescr to hash
> > > rNN-MMMMM-gXXXXX (perhaps limit X to hashes here, i.e. 7-40 hex digits)
> > - gitweb with XXXXX
> >
>
> Why complicate this with the added 'g'?
The advantage of the g in there is that git then can directly understand it:
git rev-parse r9-7160-ga5bc16f3199
a5bc16f3199c9aa43aec5af2c2839a1cd4bfce1e
while if the g is removed, it doesn't.
Jakub
