On Mon, Dec 02, 2019 at 08:24:47PM +0000, Joseph Myers wrote: > On Mon, 2 Dec 2019, Segher Boessenkool wrote: > > > Sure; I'm just saying rewriting old commit messages in such a style that > > they keep standing out from new ones is a bit of a weird choice. > > I'd say the rewrites make them stand out *less* (if people avoid having > new commit messages whose summary line is just the ChangeLog header line).
New commits will not start with [smth] in general. Of course you *can* do that, with enough effort. You can also have two consecutive empty lines in your commit messages just fine, but git won't let you without a fight. This is similar. > Simply having the Legacy-ID in the commit message will be a visible > difference from new commit messages. But I'm happy it's desirable to have > it there, because references to SVN revisions in list archives are so > common and having it in the commit messages makes it very quick and easy > to map to a git commit id, without needing any on-the-side lists of commit > mappings or other tools. Yes. Either in the subject line, or later in the commit message (as with git-svn). We can quibble about where is best, but (hopefully) everyone agrees we need the SVN id *somewhere* :-) Segher
