May I make a subject line change please ? This issue is trivial trailing whitespace changes I think and procedures, process and notice of such changes.
-- Dennis Clarke dcla...@opensolaris.ca <- Email related to the open source Solaris dcla...@blastwave.org <- Email related to open source for Solaris ---------------------------- Original Message ---------------------------- Subject: [ Three letter acronym deleted ] From: "Richard Guenther" <rguent...@suse.de> Date: Wed, November 25, 2009 14:43 To: "Richard Kenner" <ken...@vlsi1.ultra.nyu.edu> Cc: m...@suse.de gcc@gcc.gnu.org hongjiu...@intel.com l...@redhat.com -------------------------------------------------------------------------- On Wed, 25 Nov 2009, Richard Guenther wrote: > On Wed, 25 Nov 2009, Richard Kenner wrote: > > > > In my mind it's very simple: trailing whitespace poses exactly _no_ > > > problem (except of being against the coding standard), > > <snip> > But different timing or a notice wouldn't fix one of my no longer > applying patches. If you can offer advice on how to teach quilt > (which I belive uses patch) to ignore whitespace changes when > applying patches then more power to you - the only tool that > seems to be able to ignore whitespace changes is diff. Btw, I'd be happy with a commit hook that forces you to fix whitespace in the area you patch (basically just make sure there is no trailing whitespace in ^[+ ] lines of a unified diff (maybe even only in ^+ lines to not cause continuous rejects if you fixup the ^ lines in your patch and drag in more context). Anyone willing to implement that? I still see no point in fixing up the existing source just for the sake of it. Richard.