On 11/25/09 10:09, Michael Matz wrote:
Hi,
On Wed, 25 Nov 2009, Jeff Law wrote:
On 11/25/09 09:51, Richard Kenner wrote:
Can someone please remove this revision from the subversion database
on the server and fix things up? If that's not possible at least
the revision should be reverted.
Why the latter? I agree with the problems this can cause, but if they
can't be fixed by removing it from the database, why revert it? All things
being equal, trailing blanks in fact aren't a good idea.
I agree with Kenner here. We've encouraged removal of trailing
whitespace in the past
Not as bulk changes that don't do anything else, rather only as part of
changes that touch the relevant parts anyway.
Yes we have allowed this kind of change in-bulk without changing
anything else.
In many ways I prefer the bulk change -- once done you don't have to
worry about it again for a long time. Of course one could claim HJ's
timing is terrible.
and I don't why this should be any different. It does make things
marginally harder when dealing with branches,
And local patches. Basically _no_ patch will apply anymore as HJ changed
every single file. That's not something marginally harder, it's terrible
pointless thankless work created by a single 500 KB svn commit. svn blame
will now also point to HJ most of the time, wonderful!
A horrible exaggeration. Patches should be applying just fine, though
you might need the magic switch to allow whitespace differences
sometimes. I could believe automatic merging gets mucked up depending
on how it's implemented within svn/svnmerge. But it's also a
manageable problem.
As for svn blame calling out HJ, well, there's a certain poetic justice
in that.
In an ideal world, yes. But it's not a clever idea to burn down the house
just because the walls have some dots nobody cares about.
I know other projects have done this kind of thing, so it can't be that
terribly difficult to implement. Hell, a poor mans way would be a
nightly script to check out the tree and removing the trailing whitespace.
So I continue to maintain the real problem here is HJ just blasted in
his patch without posting it or even warning anyone about it. That's
bad. Really bad.
jeff
