Basile STARYNKEVITCH wrote: > FWIW, I am not taking this question personally (I don't really claim > that I could become any kind of reviewer; I believe in general that > reviewing abilities should be evaluated by others.). I just think the > set of reviewers should significantly grow.
But that needs more experts. The set of reviewers is not limited by the steering committee but by the number of experts in the world that are willing to review patches. >>> My feeling is on the contrary that the set of people having a real >>> knowledge of gcc (or at least of substantial parts of it [*]) is much >>> bigger than the set of reviewers allowed to say OK. >>>> >> > I am not at the summit. So I don't know if my perception "there are not > enough reviewers" [0] is shared by others or not. I suppose it is agreed > (that the set of reviewers should be increased [1]) If not, ignore the > rest. I really don't know if other people believe (as I do) that the set > of reviewers should significantly increase. Everyone agrees that life would be better if there were more suitably qualified gcc maintainers to approve patches. I don't have to ask anyone to know that. >> It is quite possibly the case that some maintainers should be "promoted". >> But it isn't sufficient to have a blanket policy of "let's have more >> reviewers". > But we first should agree on the wish than an increase of the set of > reviewers is desirable. It's not in any doubt. What is in doubt is that we should reduce the quality threshold in order to get them. >> We need something more like "I think Fred Bloggs knows gcc >> well enough to approve patches to reload" or "I am Fred Bloggs and I >> know gcc well enough to approve patches to reload." > I am not sure to parse correctly this sentence. Sorry, English is a > foreign language to me. Is "reload" some functionality (PCH?) you refer > inside GCC, or is it the task of making reviews on patches submitted on > gcc-patches@ ? I was just thinking about stuff like "Fred Bloggs knows > enough to approve patches submitted on gcc-patches@ to files gcc/ggc*.[ch]" This is going to sound rude, but if you don't know what reload is you're not able to talk about gcc maintenance. Andrew.
