On Feb 17, 2005, at 4:18 PM, Joe Buck wrote:

On Thu, Feb 17, 2005 at 03:47:03PM -0800, Matt Austern wrote:
I'm sure there are still lots of horrible bugs, which will only be
found with a more complete test suite. But the core functionality
works, and at this point I think it'll improve faster in the CVS server
than sitting on my hard disk.


OK to commit to mainline?

A namespace purity nitpick:

You define a macro named tr1_hashtable_define_trivial_hash.  Shouldn't
that be __tr1_hashtable_define_trivial_hash or something similar?

That was deliberate---perhaps a wrong choice, but deliberate. I didn't uglify any of the names.


Rationale: I don't believe uglification is a practical issue, but a standards-conformance issue. TR1 components aren't part of the standard, so that issue doesn't apply.

                        --Matt



Reply via email to