On Feb 17, 2005, at 4:03 PM, Paolo Carlini wrote:

Matt Austern wrote:

OK to commit to mainline?

... before going to sleep, two very simple, slighlty less enthusiastic comments ;)
1- Please add 2005 to the copyrights.

Fixed.

2- I see that the table of primes assumes that unsigned long is 32-bit: we should do something about this, sooner or later...

Yep. Or more precisely, it assumes we don't care about having more than 4 billion buckets even on 64-bit systems. I agree that this is something to take care of. But much more urgent is figuring out a way to have .cc files for TR1 components, not just header files, so we don't have to include that table in every translation unit that wants t use hashtables.


                        --Matt



Reply via email to