On Tue, Nov 11, 2014 at 10:49 AM, Andi Kleen <a...@firstfloor.org> wrote: > Joseph Myers <jos...@codesourcery.com> writes: > >> On Tue, 11 Nov 2014, Ilya Enkovich wrote: >> >>> Hi, >>> >>> This patch integrates MPX runtime library into GCC source tree. MPX >>> runtime is responsible for initialization of MPX feature in HW, signal >>> handling, reporting etc. Library is linked to codes compiled with >>> -mmpx. >>> >>> Bootstrap is OK for x86_64-unknown-linux-gnu. OK for trunk? >> >> Please use symbol versioning to control the set of exports for the >> library; only symbols explicitly listed to be exported at a given symbol >> version should be exported. > > Also I think you need some user documentation on the implications of the > overriding of sigaction. If someone else wants to do similar tricks (and > I'm sure some do) there would be conflicts. > > Really it would be far better if the signal handler chaining was done > in glibc. >
It is similar to libsanitizer. Put it in glibc isn't going to work well for MPX. -- H.J.
