On Tue, 11 Nov 2014, Joseph Myers wrote:

> You have lots of static writable variables.  Are you sure all those 
> variables are handled in a thread-safe way (e.g. only modified before any 
> threads start)?

Another general multi-thread issue for libraries: files should be opened 
with O_CLOEXEC (that's the "e" flag to fopen when using glibc) unless you 
have a clear reason not to do so.

-- 
Joseph S. Myers
jos...@codesourcery.com

Reply via email to