On 07/02/2025 11:44, Tobias Burnus wrote:
Andrew Stubbs wrote:
On 07/02/2025 09:40, Tobias Burnus wrote:
This patch permits loading generic ISA code objects - by just
trying whether the runtime accepts it. If not, it fails with
an error. - The error messages should be a bit more helpful in
some cases as before.
...
Also I think all the sentences should finish with '.'.
Thanks for proof reading. Updated patch attached.
I also added the final sentence-end period, for consistency. But I note
that this is a plugin-gcn-ism; there is even a GCC warning that
'warning_at'/error_at' diagnostic does not end with a full stop.
OK for mainline?
Tobias
PS: Pending patches:
* mkoffload.cc: switch -march= to generic version if it has a multilib
and the specific one hasn't
* amdhsa.version fix
And otherwise to do:
* [Waiting for ROCm update] plugin-gcn: Suggest -march=gfx*-generic
besides -march=gfx<specific>.
* Update install.texi – could be done now or once ROCm supports it?
Cf. original patch https://gcc.gnu.org/pipermail/gcc-patches/2025-
February/675200.html for the last two.
OK
Andrew
