On 07/02/2025 00:25, Tobias Burnus wrote:
After spending some time with the debugger, I am now convinced that ROCm 6.3.2 does not yet support generic. The amd-staging branch at https://github.com/ROCm/ROCR-Runtime/ support does, albeit only after the tag rocm-6.3.2. However, the released ROCm 6.3.2 does not match that tagged commit as it seems to contain at least the much newer commit eec21304 (but not the generic support that appeared in an in-between commit.) [AOMP is also different; it seems as if 20.0-1 does not support it, but 20.0-2 might; AOMP does not seem to have commit eec21304 to confuse things.]* * * The attached patch now adds gfx9-generic - alongside the existing gfx{10-3,1}-generic and all gfx* that are enabled by those. See previous thread for the related discussions. OK for mainline?
What happened to the documentation patch with the "Experimental" markers? I'm still uncomfortable with adding so many untested devices, so the documentation is important.
Otherwise, this patch seems fine (I have not reviewed the new magic numbers and settings.)
Andrew
(This patch depends on the just submitted patch: "[Patch] [gcn] Fix gfx906's sramecc setting", https://gcc.gnu.org/pipermail/gcc-patches/2025-February/675251.html ) * * * RFC: The patch currently does not document any gfx*-generic nor the gfx902 etc. I wonder whether a follow-up patch should just add the non-generic ones with "(Experimental)" to invoke.texi? Or any better ideas regarding what to make available now and what only later, once a generic-supporting ROCm is available? In other words: What bits of: https://gcc.gnu.org/pipermail/gcc-patches/2025-February/675200.html ? Tobias
