On 07/02/2025 11:16, Tobias Burnus wrote:
Andrew Stubbs wrote:
Otherwise, this patch seems fine (I have not reviewed the new magic
numbers and settings.)
As Andrew mentioned via chat, we also have to update the 'amdhsa.version'.
Well, that's what the attached patch does. (I have no idea which tool /
library relies on it, but it makes sense to use the right value.)
OK for mainline? (*)
Tobias
(*) Loosely tested with offloading with a ROCm 6.0.2 and 6.3.2 runtime;
however, the 1.0 was accepted by ROCm also for v4 and as generic does
not work, v6' 1.1 could not really be tested. However, looking at the
ROCR code and during debugging, I did not spot any issue with it.
Actually the string 'amdhsa' does not appear at all in ROCR.
PS: If you wonder where V6 is set: that's a few lines up in the .awk file.
OK
Andrew
