Re: [PATCH v5] RISC-V: Add a new constraint to ensure that the vl of XTheadVector does not get a non-zero immediate

[Jeff Law]

On 1/21/25 6:11 AM, Jin Ma wrote:

Although we have handled the vl of XTheadVector correctly in the
expand phase and predicates, the results show that the work is
still insufficient.

In the curr_insn_transform function, the insn is transformed from:
(insn 69 67 225 12 (set (mem:RVVM8SF (reg/f:DI 218 [ _77 ]) [0  S[128, 128] 
A32])
         (if_then_else:RVVM8SF (unspec:RVVMF4BI [
                     (const_vector:RVVMF4BI repeat [
                             (const_int 1 [0x1])
                         ])
                     (reg:DI 209)
                     (const_int 0 [0])
                     (reg:SI 66 vl)
                     (reg:SI 67 vtype)
                 ] UNSPEC_VPREDICATE)
             (reg/v:RVVM8SF 143 [ _xx ])
             (mem:RVVM8SF (reg/f:DI 218 [ _77 ]) [0  S[128, 128] A32])))
      (expr_list:REG_DEAD (reg/v:RVVM8SF 143 [ _xx ])
         (nil)))
to
(insn 69 284 225 11 (set (mem:RVVM8SF (reg/f:DI 18 s2 [orig:218 _77 ] [218]) [0 
 S[128, 128] A32])
         (if_then_else:RVVM8SF (unspec:RVVMF4BI [
                     (const_vector:RVVMF4BI repeat [
                             (const_int 1 [0x1])
                         ])
                     (const_int 1 [0x1])
                     (const_int 0 [0])
                     (reg:SI 66 vl)
                     (reg:SI 67 vtype)
                 ] UNSPEC_VPREDICATE)
             (reg/v:RVVM8SF 104 v8 [orig:143 _xx ] [143])
             (mem:RVVM8SF (reg/f:DI 18 s2 [orig:218 _77 ] [218]) [0  S[128, 
128] A32])))
      (nil))

Looking at the log for the reload pass, it is found that "Changing pseudo 209 in
operand 3 of insn 69 on equiv 0x1".
It converts the vl operand in insn from the expected register(reg:DI 209) to the
constant 1(const_int 1 [0x1]).

This conversion occurs because, although the predicate for the vl operand is
restricted by "vector_length_operand" in the pattern, the constraint is still
"rK", which allows the transformation.

The issue is that changing the "rK" constraint to "rJ" for the constraint of vl
operand in the pattern would prevent this conversion, But unfortunately this 
will
conflict with RVV (RISC-V Vector Extension).

Based on the review's recommendations, the best solution for now is to create
a new constraint to distinguish between RVV and XTheadVector, which is exactly
what this patch does.

        PR 116593

gcc/ChangeLog:

        * config/riscv/constraints.md (vl): New.
        * config/riscv/thead-vector.md: Replacing rK with rvl.
        * config/riscv/vector.md: Likewise.

gcc/testsuite/ChangeLog:

        * g++.target/riscv/rvv/rvv.exp: Enable testsuite of XTheadVector.
        * g++.target/riscv/rvv/xtheadvector/pr116593.C: New test.

I've pushed this to the trunk as well.

Thanks,
jeff