On Wed, Nov 20, 2024 at 1:25 AM Claudio Bantaloukas <claudio.bantalou...@arm.com> wrote: > > > On 19/11/2024 17:01, Andrew Pinski wrote: > > On Fri, Nov 8, 2024 at 8:11 AM Claudio Bantaloukas > > <claudio.bantalou...@arm.com> wrote: > >> > >> According to the aapcs64: If the argument is an 8-bit (...) precision > >> Floating-point or short vector type and the NSRN is less than 8, then the > >> argument is allocated to the least significant bits of register v[NSRN]. > >> > >> gcc/ > >> * config/aarch64/aarch64.cc > >> (aarch64_vfp_is_call_or_return_candidate): use fp registers to > >> return svmfloat8_t parameters. > >> > >> gcc/testsuite/ > >> * gcc.target/aarch64/fp8_scalar_1.c: > > This changed fp8_scalar_1.c's stacktest1 body but the generated code > > there changed to be just: > > sub sp, sp, #16 > > str b0, [sp, 15] > > ldr b0, [sp, 15] > > add sp, sp, 16 > > ret > > > > Instead of having to require a move to the GPRs. > > This code generation seems correct for what it is testing. Did > > something else change the generated code after you made the change to > > the testcase or was it still failing? > > Hi Andrew, > > there are quite a few changes around parameter passing in patch 2/4. > > Files under gcc/testsuite/gcc.target/aarch64/sve/acle/asm/ > <https://reviewboard.gnu.aws.arm.com/r/18917/diff/2-3/?page=2#11> have > changed. For example, in lastb_mf8.c > > lastbw0, p0, z0\.b > > became > > lastbb0, p0, z0\.b > > Under gcc/testsuite/gcc.target/aarch64/sve/pcs/, return_4.c and similar, > there used to be a > > umovw0, v0.b\[0\] > > which is no longer needed and > > movz0\.b, w4 in calees have become movz0\.b, b4 > > Also in varargs_2_mf8.c the change altered register allocation. > > It was an oversight of mine that I should have mentioned, along with"A > change has been added to fix return of scalar fp8 values" that multiple > tests have been updated to reflect the return.
Actually I looked again and stacktest1 was working when you committed your patch but was improved with r15-5375-gbeec291225be . See https://gcc.gnu.org/pipermail/gcc-regression/2024-November/081270.html . I will push a fix for the testcase later today. Thanks, Andrew Pinski > > Cheers, > > Claudio > > > > > Thanks, > > Andrew > > > > > >> --- > >> gcc/config/aarch64/aarch64.cc | 3 ++- > >> gcc/testsuite/gcc.target/aarch64/fp8_scalar_1.c | 4 ++-- > >> 2 files changed, 4 insertions(+), 3 deletions(-) > >>
