> -----Original Message-----
> From: H.J. Lu <hjl.to...@gmail.com>
> Sent: Friday, August 23, 2024 6:07 PM
> To: gcc-patches@gcc.gnu.org
> Cc: Prathamesh Kulkarni <prathame...@nvidia.com>;
> richard.guent...@gmail.com
> Subject: [PATCH] lto: Don't check obj.found for offload section
> 
> External email: Use caution opening links or attachments
> 
> 
> obj.found is the number of LTO symbols.  We should include the offload
> section when it is used by linker even if there are no LTO symbols.
> 
>         PR lto/116361
>         * lto-plugin.c (claim_file_handler_v2): Don't check obj.found
>         for the offload section.
Hi,
I applied your patch locally, and can confirm this fixes the issue with 
offloading, thanks!

Thanks,
Prathamesh
> 
> Signed-off-by: H.J. Lu <hjl.to...@gmail.com>
> ---
>  lto-plugin/lto-plugin.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lto-plugin/lto-plugin.c b/lto-plugin/lto-plugin.c index
> 61b0de62f52..c564b36eb92 100644
> --- a/lto-plugin/lto-plugin.c
> +++ b/lto-plugin/lto-plugin.c
> @@ -1320,7 +1320,7 @@ claim_file_handler_v2 (const struct
> ld_plugin_input_file *file,
>    if (*can_be_claimed && !obj.offload && offload_files_last_lto ==
> NULL)
>      offload_files_last_lto = offload_files_last;
> 
> -  if (obj.offload && known_used && obj.found > 0)
> +  if (obj.offload && known_used)
>      {
>        /* Add file to the list.  The order must be exactly the same as
> the final
>          order after recompilation and linking, otherwise host and
> target tables
> --
> 2.46.0

Reply via email to