On Thu, Aug 08, 2024 at 10:01:14PM +0200, Alejandro Colomar wrote:
> Hi Joseph,
>
> On Thu, Aug 08, 2024 at 05:31:05PM GMT, Joseph Myers wrote:
> > Actual bugs should of course be fixed.
>
> Here are the suspects:
>
> ./gcc/testsuite/gcc.target/powerpc/sse3-addsubps.c:80:
> for (i = 0; i < sizeof (vals) / sizeof (vals); i += 8)
>
> ./gcc/c-family/c-pragma.cc:1811:
> = sizeof (omp_pragmas_simd) / sizeof (*omp_pragmas);
>
> The second sizeof expression seems to have a bogus operand, and the
> correct one is probably the common one in sizeof divisions.
While the c-pragma one looks suspect and should be using ARRAY_SIZE (I'll
post a patch), it actually works correctly.
Both omp_pragmas and omp_pragmas_simd are arrays of the same structure, so
whether it divides by sizeof (*omp_pragmas) or sizeof (*omp_pragmas_simd)
or sizeof (omp_pragmas_simd[0]) doesn't matter.
Jakub
