On Thu, Aug 08, 2024 at 08:36:36PM GMT, Joseph Myers wrote: > On Thu, 8 Aug 2024, Alejandro Colomar wrote: > > > Here are the suspects: > > > > ./gcc/testsuite/gcc.target/powerpc/sse3-addsubps.c:80: > > for (i = 0; i < sizeof (vals) / sizeof (vals); i += 8) > > The key question for testcases is *does the test actually test what was > intended*? We never want to change testcases simply for cleanness or > consistency; being inconsistent is actively good in the testsuite, which > should cover as wide a variety of weird code as possible.
I suspect it doesn't test what was intended. sizeof(vals)/sizeof(vals) is 1, which doesn't look like intended at all. Also, there were related tests that had the proper division. > > -- > Joseph S. Myers > josmy...@redhat.com > -- <https://www.alejandro-colomar.es/>
signature.asc
Description: PGP signature
