Hi FX,
> The fixincludes fix “math_exception” is being applied overly broadly,
> including many targets which don’t need it, like darwin (and probably all
> non-glibc targets). I’m not sure if it is still needed on any target, but
> because I can’t be absolutely positive about that, I don’t want to remove
> it. But it dates from before 1998.
right: that's the ugly thing about those fixes that aren't restricted to
particular targets. Even if they were introduced for a specific set of
targets initially, there's no way of knowing if they are aren't needed
elsewere, too. In fact, they *may* be needed and nobody nobody noticed
because the fix was already in place. This makes them almost impossible
to get rid of.
> In subsequent times (2000) it was bypassed on glibc headers, as well as
> Solaris 10. It was still needed on Solaris 8 and 9, which are (AFAICT)
> unsupported nowadays. The fix was originally bypassed on __cplusplus, which
> is the correct thing to do, but that bypass was neutralized to cater to a
> bug on Solaris 8 and 9 headers. Now that those are gone… let’s revert to
Solaris 8 and 9 support is long gone from trunk. In fact, the only
Solaris version supported there is 11.4.
However, please note that the comment states
* This should be bypassed on __cplusplus, but some supposedly C++
* aware headers, such as Solaris 8 and 9, don't wrap their struct
It's "such as Solaris 8 and 9", so there may well be others. Commercial
OSes in particular can retain their headers (bugs and all) for very long
times ;-( It make take quite some insistence from customers or
developes to have them changed (I know all too well from the Solaris
side of things, and you probably have similar experiences for Darwin).
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
