:-D Looks good to me. EXCEPT I think the test sample file would need a
change, too. I didn't see that.
On 6/7/24 02:37, FX Coudert wrote:
The fixincludes fix “math_exception” is being applied overly broadly, including
many targets which don’t need it, like darwin (and probably all non-glibc
targets). I’m not sure if it is still needed on any target, but because I can’t
be absolutely positive about that, I don’t want to remove it. But it dates from
before 1998.
In subsequent times (2000) it was bypassed on glibc headers, as well as Solaris
10. It was still needed on Solaris 8 and 9, which are (AFAICT) unsupported
nowadays. The fix was originally bypassed on __cplusplus, which is the correct
thing to do, but that bypass was neutralized to cater to a bug on Solaris 8 and
9 headers. Now that those are gone… let’s revert to the previous bypass.
Bootstrapped and regtested on x86_64-apple-darwin23, where it no longer “fixes”
the header unnecessarily.
OK to push?
FX
