Where is the patch -- the code review link is missing (in the original post).
David On Sun, Jun 3, 2012 at 6:14 AM, Dehao Chen <de...@google.com> wrote: > Thank you guys for the comments, I'll update the patch to : > > 1. generalize the flag to enable other annotations such always_inline. > 2. change to use deferred option. > > Thanks, > Dehao > > On Sun, Jun 3, 2012 at 12:40 PM, Xinliang David Li <davi...@google.com> wrote: >> On Sat, Jun 2, 2012 at 11:11 AM, Jan Hubicka <hubi...@ucw.cz> wrote: >>>> Actually Dehao also plans to teach the static predictor to understand >>>> standard library functions more (e.g IO functions) and add more naming >>> >>> How this differ from annotating the library? >> >> I find them more suitable to be compiler heuristic than being >> function's attribute -- attribute is a much stronger assertion. >> >>> >>> There are indeed quite some possibilities to do about library calls.... >>> >>> One thing I always wondered about is how to tell predictor that paths >>> containing >>> heavy IO functions don't need to be really opimized to death, since their >>> execution >>> time is dominated by the IO... >>> >> >> Yes -- if branch predictor does the right thing and if function >> splitter is powerful enough, the IO code can be outlined and optimized >> for size :) >> >> >>>> based heuristics such as 'error, success, failure, fatal etc). >>> >>> yeah, this is also mentioned by some branch prediction papers. It is bit >>> kludgy >>> in nature (i.e. it won't understand programs written in Czech language) but >>> it >>> is an heuristics after all. >>> >> >> right. >> >> thanks, >> >> David >> >>> Honza >>>> >>>> thanks, >>>> >>>> David >>>> >>>> > Honza >>>> >> >>>> >> thanks, >>>> >> >>>> >> David >>>> >> > Honza
