> > Well, perhaps the feature would be more useful with command line option 
> > allowing
> > to add an attribute instead of having special case command line options for 
> > individual
> > cases.
> 
> Hi, Honza, I'm not sure what you mean by "command line option allowing
> to add an attribution". But this seems what this patch does: it adds
> attributes to functions with specified name patterns.

I mean that if we want to go this route, we may want to allow this interface to 
i.e. add
always_inline attrbute or noinline or such. I can imagine this to be useful 
especially for
languages that has no attributes.

> 
> >  I guess the problem would be also solvable with header included after
> > the library adding the attributes to the declarations
> >
> > typeof (printf) printf __attribute__ ((cold));
> 
> Do you mean that for each specific application, we extract a common
> header file to include all function annotations, and all source files
> will include this header file?

Yes, something like that...
Where do you use the likely_hot/likely_cold logic?

Honza
> 
> Thanks,
> Dehao
> 
> >
> > Honza
> >>
> >> thanks,
> >>
> >> David
> >> > Honza

Reply via email to