On Mon, Jun 4, 2012 at 9:34 AM, Andi Kleen <a...@firstfloor.org> wrote:
> Dehao Chen <de...@google.com> writes:
>
>> Hi,
>>
>> This patch adds 4 flags to enable user to type in a list of name
>> patterns. Compiler will match the function name with the given
>> patterns, and add "hot", "cold", "likely_hot", "likely_cold"
>> attributes to function declaration. The static branch prediction
>> checks if a basic block contains call to a annotated function, and set
>> the branch probability accordingly.
>
> I like the idea (and would have some uses for it), but I don't like the
> command line options. That will lead to longer and longer command
> lines. Could this be made a pragma instead?
>
> You could still specify it from the Makefile by using -include

Thanks for the suggestions.

How about we add an option (-ffunction-attribute-list=), and we can
also specify this option using "#pragma GCC optimize" in a separate
-include file?

Thanks,
Dehao

>
> -Andi
>
> --
> a...@linux.intel.com -- Speaking for myself only

Reply via email to