RE: [PATCH 01/10] arm: [MVE intrinsics] add unary shape

[Kyrylo Tkachov via Gcc-patches]

> -----Original Message-----
> From: Christophe Lyon <christophe.l...@arm.com>
> Sent: Friday, May 5, 2023 5:49 PM
> To: gcc-patches@gcc.gnu.org; Kyrylo Tkachov <kyrylo.tkac...@arm.com>;
> Richard Earnshaw <richard.earns...@arm.com>; Richard Sandiford
> <richard.sandif...@arm.com>
> Cc: Christophe Lyon <christophe.l...@arm.com>
> Subject: [PATCH 01/10] arm: [MVE intrinsics] add unary shape
> 
> This patch adds the unary shape description.

I had looked at the series over the weekend, the series is ok for trunk.
Thanks,
Kyrill

> 
> 2022-09-08  Christophe Lyon  <christophe.l...@arm.com>
> 
>       gcc/
>       * config/arm/arm-mve-builtins-shapes.cc (unary): New.
>       * config/arm/arm-mve-builtins-shapes.h (unary): New.
> ---
>  gcc/config/arm/arm-mve-builtins-shapes.cc | 27 +++++++++++++++++++++++
>  gcc/config/arm/arm-mve-builtins-shapes.h  |  1 +
>  2 files changed, 28 insertions(+)
> 
> diff --git a/gcc/config/arm/arm-mve-builtins-shapes.cc b/gcc/config/arm/arm-
> mve-builtins-shapes.cc
> index 7078f7d7220..7d39cf79aec 100644
> --- a/gcc/config/arm/arm-mve-builtins-shapes.cc
> +++ b/gcc/config/arm/arm-mve-builtins-shapes.cc
> @@ -786,6 +786,33 @@ struct inherent_def : public nonoverloaded_base
>  };
>  SHAPE (inherent)
> 
> +/* <T0>_t vfoo[_t0](<T0>_t)
> +
> +   i.e. the standard shape for unary operations that operate on
> +   uniform types.
> +
> +   Example: vabsq.
> +   int8x16_t [__arm_]vabsq[_s8](int8x16_t a)
> +   int8x16_t [__arm_]vabsq_m[_s8](int8x16_t inactive, int8x16_t a,
> mve_pred16_t p)
> +   int8x16_t [__arm_]vabsq_x[_s8](int8x16_t a, mve_pred16_t p)  */
> +struct unary_def : public overloaded_base<0>
> +{
> +  void
> +  build (function_builder &b, const function_group_info &group,
> +      bool preserve_user_namespace) const override
> +  {
> +    b.add_overloaded_functions (group, MODE_none,
> preserve_user_namespace);
> +    build_all (b, "v0,v0", group, MODE_none, preserve_user_namespace);
> +  }
> +
> +  tree
> +  resolve (function_resolver &r) const override
> +  {
> +    return r.resolve_unary ();
> +  }
> +};
> +SHAPE (unary)
> +
>  /* <T0>_t foo_t0[_t1](<T1>_t)
> 
>     where the target type <t0> must be specified explicitly but the source
> diff --git a/gcc/config/arm/arm-mve-builtins-shapes.h b/gcc/config/arm/arm-
> mve-builtins-shapes.h
> index 09e00b69e63..bd7e11b89f6 100644
> --- a/gcc/config/arm/arm-mve-builtins-shapes.h
> +++ b/gcc/config/arm/arm-mve-builtins-shapes.h
> @@ -45,6 +45,7 @@ namespace arm_mve
>      extern const function_shape *const binary_rshift_narrow_unsigned;
>      extern const function_shape *const create;
>      extern const function_shape *const inherent;
> +    extern const function_shape *const unary;
>      extern const function_shape *const unary_convert;
> 
>    } /* end namespace arm_mve::shapes */
> --
> 2.34.1