On Tue, 2022-10-04 at 21:45 +0800, LIU Hao wrote: > 在 2022-10-04 21:13, Xi Ruoyao 写道: > > > > In GCC development we usually include the configure regeneration in the > > patch because the scripts are also version controlled. > > > > There is a reason for not doing that: Generated contents can't be reviewed. > > In mingw-w64 we do the opposite: The person who commits a patch is > responsible for update configure, > Makefile.in, etc. The patch itself doesn't include generated contents.
The reviewer can simply skip the changes in configure. But including the configure allows the potential testers to test the change without autoconf-2.69 installed. Maybe we can make a compromise: put the line "configure: Regenerate." in the ChangeLog, but do not actually include the change. Now if the committer forgot to regenerate it, the git hook will reject the push immediately. (Just my 2 cents.) -- Xi Ruoyao <xry...@xry111.site> School of Aerospace Science and Technology, Xidian University
