I don't really understand MinGW, but some "non-technical" things:
On Tue, 2022-10-04 at 20:44 +0800, LIU Hao via Gcc-patches wrote: > After applying these patches, configure scripts in these > subdirectories need to be regenerated: > > * gcc > * libgcc > * libatomic > * libstdc++-v3 In GCC development we usually include the configure regeneration in the patch because the scripts are also version controlled. > The patch for libgfortran fixes > > * https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105764 It's better to include the ID in the subject and ChangeLog of the patch. Like: [PATCH 1/3] libgfortran: Use `__gthread_t` instead of `pthread_t` [PR 105764] It used to cause errors if a thread model other than `posix` was selected, which looks like a leftover from a79878585a1c5e32bafbc6d1e73f91fd6e4293bf. libgfortran/ChangeLog: PR libgfortran/105764 * io/async.h (struct async_unit): Use `__gthread_t` instead of `pthread_t`. This allows a git hook to append a message into the PR 105764 entry in bugzilla once the patch is committed into trunk. Normally I leave an empty line after "ChangeLog:" but I'm not sure if it's strictly needed. > gcc/config/ChangeLog: > * i386/mingw-mcfgthread.h: New file > * i386/mingw32.h: Add builtin macro and default libraries for > mcfgthread when thread model is `mcf` Normally I leave a "." for each ChangeLog entry, but I'm not sure if it's strictly needed. However there is no gcc/config/ChangeLog, use gcc/ChangeLog instead. And, from https://gcc.gnu.org/contribute.html#patches: "It is strongly discouraged to post patches as MIME parts of type application/whatever, disposition attachment or encoded as base64 or quoted-printable." Just try "git send-email", it will do the correct thing. Mimicking its behavior in a mail client is also possible but error-prune (the mail client can destroy your patch by replacing your tabs with spaces, etc.) -- Xi Ruoyao <xry...@xry111.site> School of Aerospace Science and Technology, Xidian University
